add IPv6 support#752
Open
yibozhuang wants to merge 1 commit into
Open
Conversation
Extends the network plumbing to support per-interface IPv6 address configuration. The `Interface` protocol supports `ipv6Address` and `ipv6Gateway`. The agent's networking RPCs carry per-family fields via new `InterfaceAddress`, `LinkRoute`, and `DefaultRoute` types in `ContainerizationExtras`. `NetlinkSession` adds IPv6 methods for address and route operations. Co-authored-by: Michael Crosby <crosbymichael@gmail.com>
dcantah
reviewed
May 27, 2026
Member
There was a problem hiding this comment.
VirtualMachineAgent+Interface.swift?
dcantah
reviewed
May 27, 2026
| if ipv4Gateway == nil && ipv6Gateway == nil { | ||
| logger?.debug("no gateway for \(name)") | ||
| } | ||
| try await routeAddDefault( |
Member
There was a problem hiding this comment.
Is this something we can skip if v4 and v6 gateway are both nil?
dcantah
reviewed
May 27, 2026
| /// - id: The container ID. | ||
| /// - ipv6Address: The IPv6 CIDR address to assign to the interface. | ||
| /// - ipv6Gateway: The IPv6 gateway address for the default route. | ||
| public mutating func createInterface(_ id: String, ipv6Address: CIDRv6, ipv6Gateway: IPv6Address? = nil) throws -> Containerization.Interface? { |
Member
There was a problem hiding this comment.
Dumb question, this call was supposed to be the "just give me a NIC" call that ContainerManager can use. Can our allocator not be extended to also give us a v6 addr?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the network plumbing to support per-interface IPv6 address configuration.
The
Interfaceprotocol supportsipv6Addressandipv6Gateway.The agent's networking RPCs carry per-family fields via new
InterfaceAddress,LinkRoute, andDefaultRoutetypes inContainerizationExtras.NetlinkSessionadds IPv6 methods for address and route operations.